Skip to content

[18.0][OU-ADD] l10n_fr#5090

Merged
MiquelRForgeFlow merged 1 commit into
OCA:18.0from
lefilament:18.0-add-l10n_fr
Jun 6, 2025
Merged

[18.0][OU-ADD] l10n_fr#5090
MiquelRForgeFlow merged 1 commit into
OCA:18.0from
lefilament:18.0-add-l10n_fr

Conversation

@remi-filament

Copy link
Copy Markdown

No description provided.

@remi-filament

Copy link
Copy Markdown
Author

Hi @legalsylvain @hbrunn @MiquelRForgeFlow @pedrobaeza

While looking at migrating l10n_fr which has largely been moved to l10n_fr_account (all accounting data : chart of account, taxes, etc.). I realize that module l10n_fr_fec has also been moved to l10n_fr_account.

In apriori.py file this module is marked as merged in l10n_fr which is incorrect (and therefore analysis is also incorrect since it considers that FEC related stuff has been removed from l10n_fr and added in l10n_fr_account).

However, I am not sure how to handle that since l10n_fr_account did not exist before, should we consider that l10n_fr_fec has been renamed to l10n_fr_account or does it imply side effects since l10n_fr_account is much more than only l10n_fr_fec ?
If we go with rename, then how should I handle the fact that a noupdate ir_rule from l10n_fr_fec has been removed ? I suppose this should be done in l10n_fr_account migration script, but since this is a new module, will this migration script be run ?

For now I have added the removal of ir_rule from l10n_fr_fec in this module migration script.

Thanks for your insight !

Comment thread openupgrade_scripts/scripts/l10n_fr/18.0.2.1/upgrade_analysis_work.txt Outdated
@MiquelRForgeFlow

MiquelRForgeFlow commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

@remi-filament l10n_fr_fec (that only contained a wizard) was merged into l10n_fr (see odoo/odoo@0e71e2a) before l10n_fr_account was created. But what you say is true, when l10n_fr_account was later created, they moved the wizard there. So, please, in apriori merge l10n_fr_fec to l10n_fr_account. Then you will have to do in the migration script of l10n_fr_account:

  • delete of l10n_fr_fec.account_fr_fec_rule
  • rename of wizard table and models

@MiquelRForgeFlow MiquelRForgeFlow added this to the 18.0 milestone Jun 5, 2025
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

/ocabot migration l10n_fr

/ocabot migration l10n_fr_fec

/ocabot migration l10n_fr_account

@remi-filament remi-filament marked this pull request as draft June 5, 2025 12:01
@remi-filament

Copy link
Copy Markdown
Author

Thanks @MiquelRForgeFlow , I will do as proposed !

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to put into merge modules. It doesn't change anything technically, but semantically.

Comment thread docsource/modules170-180.rst Outdated
Comment thread openupgrade_scripts/apriori.py
@remi-filament

Copy link
Copy Markdown
Author

While testing, I had an issue since Odoo tries to run end_migration script from l10n_fr_account version 2.1
The problem I had was linked to account.account which did not have the proper account_type and non_trade not set.

Therefore I made some extra post-migration script to handle those. I hope this is OK ?

@remi-filament remi-filament marked this pull request as ready for review June 5, 2025 15:26
Comment thread docsource/modules170-180.rst Outdated
Comment thread openupgrade_scripts/scripts/l10n_fr_account/18.0.2.2/upgrade_analysis_work.txt Outdated
@remi-filament

Copy link
Copy Markdown
Author

Thanks @MiquelRForgeFlow I implemented your remarks !

@MiquelRForgeFlow MiquelRForgeFlow merged commit 2916cd5 into OCA:18.0 Jun 6, 2025
4 checks passed
"""
UPDATE ir_module_module
SET state='to install'
WHERE name = 'l10n_fr_account' AND state='uninstalled'""",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where this can be conflicting, as merging the other module may have an undesired state "to install" while it should be "to upgrade".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants