[18.0][OU-ADD] l10n_fr#5090
Conversation
|
Hi @legalsylvain @hbrunn @MiquelRForgeFlow @pedrobaeza While looking at migrating l10n_fr which has largely been moved to l10n_fr_account (all accounting data : chart of account, taxes, etc.). I realize that module l10n_fr_fec has also been moved to l10n_fr_account. In apriori.py file this module is marked as merged in l10n_fr which is incorrect (and therefore analysis is also incorrect since it considers that FEC related stuff has been removed from l10n_fr and added in l10n_fr_account). However, I am not sure how to handle that since l10n_fr_account did not exist before, should we consider that l10n_fr_fec has been renamed to l10n_fr_account or does it imply side effects since l10n_fr_account is much more than only l10n_fr_fec ? For now I have added the removal of ir_rule from l10n_fr_fec in this module migration script. Thanks for your insight ! |
|
@remi-filament
|
|
/ocabot migration l10n_fr /ocabot migration l10n_fr_fec /ocabot migration l10n_fr_account |
|
Thanks @MiquelRForgeFlow , I will do as proposed ! |
fd6c186 to
0c028bc
Compare
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
I think it's better to put into merge modules. It doesn't change anything technically, but semantically.
0c028bc to
7b9cf76
Compare
|
While testing, I had an issue since Odoo tries to run end_migration script from l10n_fr_account version 2.1 Therefore I made some extra post-migration script to handle those. I hope this is OK ? |
7b9cf76 to
80ba243
Compare
|
Thanks @MiquelRForgeFlow I implemented your remarks ! |
| """ | ||
| UPDATE ir_module_module | ||
| SET state='to install' | ||
| WHERE name = 'l10n_fr_account' AND state='uninstalled'""", |
There was a problem hiding this comment.
This is where this can be conflicting, as merging the other module may have an undesired state "to install" while it should be "to upgrade".
No description provided.