[18.0][OU-ADD] account#4931
Merged
Merged
Conversation
Contributor
Author
|
/ocabot migration account |
Member
|
For reference, here are the 4 key breaking changes PR and 2 main features PR for the account module in for the v18 migration: |
MiquelRForgeFlow
force-pushed
the
18.0-mig-account
branch
10 times, most recently
from
b4974bc to
d9ac760
Compare
hbrunn
requested changes
Apr 28, 2025
hbrunn
left a comment
hbrunn
left a comment
Member
There was a problem hiding this comment.
I looked into this before my vacation and got stuck on figuring out if we need to merge accounts based on their code for multiple companies with the same localization and maybe other properties. Any opinion on that?
Review is partial up to now.
MiquelRForgeFlow
force-pushed
the
18.0-mig-account
branch
from
d9ac760 to
3dc8f8d
Compare
MiquelRForgeFlow
force-pushed
the
18.0-mig-account
branch
from
3dc8f8d to
b51a52f
Compare
MiquelRForgeFlow
force-pushed
the
18.0-mig-account
branch
from
b51a52f to
3387a69
Compare
Member
|
@MiquelRForgeFlow I'll be pushing a couple of suggestions to ForgeFlow#25 |
MiquelRForgeFlow
commented
May 5, 2025
MiquelRForgeFlow
force-pushed
the
18.0-mig-account
branch
from
0465cd9 to
7bda9b9
Compare
MiquelRForgeFlow
force-pushed
the
18.0-mig-account
branch
from
7bda9b9 to
abf60fc
Compare
This was referenced May 15, 2025
hbrunn
approved these changes
May 19, 2025
MiquelRForgeFlow
force-pushed
the
18.0-mig-account
branch
from
abf60fc to
d74b22b
Compare
This was referenced May 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Depends on :