Skip to content

[18.0] initialize+openupgrade_framework+analysis+base#4709

Merged
OCA-git-bot merged 73 commits into
OCA:18.0from
hbrunn:18.0-initialize+openupgrade_framework+analysis+base
Mar 21, 2025
Merged

[18.0] initialize+openupgrade_framework+analysis+base#4709
OCA-git-bot merged 73 commits into
OCA:18.0from
hbrunn:18.0-initialize+openupgrade_framework+analysis+base

Conversation

@hbrunn

@hbrunn hbrunn commented Jan 13, 2025

Copy link
Copy Markdown
Member

Left to do before we can sensibly start with migrating modules:

legalsylvain and others added 30 commits September 30, 2024 12:50
- Apply new copier template. (from v1.14.2 to v1.18 : replace setup by pyproject.toml, replace black by ruff, ...)
- Disable .github/workflows/test.yml because the openupgrade is not initialized yet
- add new empty modules160-170.rst file
-This commit remove unecessary patch
-Check if test exist then execute it in the test.yml
-Remove the test loader from patch, detail at
OCA#4327 (comment)
If we don't include it, /jsonrpc route doesn't work.
If you have a module in previous versions that adds data on a model,
and such model is not loaded in the registry in current version because
the module is absent in it, you can't uninstall such module, getting
this error:

  File "odoo/odoo/addons/base/models/ir_model.py", line 1945, in _module_data_uninstall
    delete(self.env[model].browse(item[1] for item in items))
  File "odoo/odoo/api.py", line 463, in __getitem__
    return self.registry[model_name]._browse(self, (), ())
  File "odoo/odoo/modules/registry.py", line 177, in __getitem__
    return self.models[model_name]
KeyError: 'model'

With this patch, data cleanup of such model is skipped and there's no crash.
…ore ; add links to the new OpenUpgrade website
@carlos-lopez-tecnativa

Copy link
Copy Markdown
Contributor

Hi @hbrunn @MiquelRForgeFlow, could you please update the status of this PR. Is it ready to merge?. I noticed that several commits could be squashed.
cc: @pedrobaeza

@MiquelRForgeFlow

MiquelRForgeFlow commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

Is it ready to merge?

@hbrunn

(also, fixup! commits should be squashed)

@hbrunn

hbrunn commented Mar 3, 2025

Copy link
Copy Markdown
Member Author

it's ready for review, mergeability is up to the reviewers to decide

@hbrunn hbrunn force-pushed the 18.0-initialize+openupgrade_framework+analysis+base branch from c09f171 to 9c6d0de Compare March 3, 2025 08:52
@hbrunn

hbrunn commented Mar 3, 2025

Copy link
Copy Markdown
Member Author

included #4796 and squashed fixup commits

Comment thread openupgrade_framework/odoo_patch/odoo/modules/migration.py
Comment thread openupgrade_scripts/scripts/base/18.0.1.3/upgrade_analysis_work.txt
Comment thread openupgrade_scripts/scripts/base/18.0.1.3/upgrade_analysis_work.txt
@legalsylvain

Copy link
Copy Markdown
Contributor

/ocabot migration base

@OCA-git-bot

Copy link
Copy Markdown
Contributor

There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment.

@legalsylvain

Copy link
Copy Markdown
Contributor

/ocabot migration base

@hbrunn hbrunn force-pushed the 18.0-initialize+openupgrade_framework+analysis+base branch from 0bf3977 to 347832d Compare March 10, 2025 19:43
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-4709-by-MiquelRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fa931d0 into OCA:18.0 Mar 21, 2025
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a96ecae. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.