Conversation
Generalizing Einasto dl_sphere_mass for any radius. Created function: nc_halo_density_profile_eval_spher_mass_delta (compute the enclosed mass within radius R_Delta). nc_halo_density_profile_eval_numint_dl_spher_mass: it computes now the enclosed mass for any radius (not only R_Delta). Updated the respective tests.
Adding setting hooks for massdef and Delta for HaloMassSummary.
Fixing tests. Removing prints.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 71.17% 71.12% -0.05%
==========================================
Files 575 577 +2
Lines 98653 98769 +116
==========================================
+ Hits 70213 70248 +35
- Misses 28440 28521 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vitenti
approved these changes
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duffy08;
Unit test for Duffy08 and Klypin11 concentration-mass relations.