fix(cli): arm detached relaunch for agent-initiated Windows restart - #110475
Open
lEWFkRAD wants to merge 1 commit into
Open
fix(cli): arm detached relaunch for agent-initiated Windows restart#110475lEWFkRAD wants to merge 1 commit into
lEWFkRAD wants to merge 1 commit into
Conversation
…n Windows (NousResearch#99215) A 'hermes gateway restart' issued from a gateway-hosted agent turn runs as a child of the gateway it stops, so the stop path tears the restart command down before it reaches its own start() -- a silent outage with nothing to relaunch (NousResearch#99215). Detect the descendant case via the ancestor chain and arm the detached restart watcher BEFORE stopping, replaying each gateway's own live 'gateway run' argv. A restart from a clean shell keeps the original synchronous stop/wait/start flow. Rebuilt onto current main from 500b6d3; adds 6 regression tests. Co-authored-by: Hermes Agent <agent@nousresearch.com>
12 tasks
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #99215 on Windows by detecting when
hermes gateway restartis running beneath the gateway process it is about to stop. In that descendant case, the CLI arms the detached restart watcher before stopping the gateway and replays each gateway's livegateway runargv. Restarts from a clean shell keep the existing synchronous stop/wait/start path.This replaces stale PR #99386, rebuilt onto current
mainafter upstream gateway lifecycle changes.Verification
tests/hermes_cli/test_gateway_windows.py: 15 passedorigin/main: 61 failed, 236 passedBehavior