fix(cli): prompt reasoning after provider route changes - #110468
Open
ehz0ah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hermes modelskipped the reasoning-effort prompt when a user changed providers but kept the same model ID. The post-picker check only comparedmodel.default, so it treated a real route change as a no-op.Track the effective provider route before the picker and compare it with the route persisted by the selected flow. Provider aliases and casing remain equivalent, while named custom endpoints, direct custom endpoint changes, and nested flows such as Bedrock API Key are handled as distinct routes. Capability lookup now uses the persisted route instead of the outer picker row.
This is a regression from the model-picker reasoning work merged in #110346. No separate issue currently tracks it.
Related Issue
No linked issue.
Type of Change
Changes Made
How to Test
scripts/run_tests.sh tests/hermes_cli/test_reasoning_effort_menu.py -q.Related suite executed:
Result: 146 passed.
Also passed:
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Not applicable. This changes interactive CLI control flow and includes behavioral regression coverage.