Skip to content

spidermonkey_52: cross compilation#58049

Merged
FRidh merged 1 commit into
NixOS:masterfrom
illegalprime:spidermonkey-cross
Apr 16, 2019
Merged

spidermonkey_52: cross compilation#58049
FRidh merged 1 commit into
NixOS:masterfrom
illegalprime:spidermonkey-cross

Conversation

@illegalprime
Copy link
Copy Markdown
Member

@illegalprime illegalprime commented Mar 21, 2019

Motivation for this change

we need spidermonkey to cross compile polkit. this is only for version 52, if this looks reasonable I can replicate this for the other versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from abbradar March 21, 2019 15:10
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 21, 2019
@illegalprime illegalprime mentioned this pull request Mar 21, 2019
Merged
10 tasks
@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Mar 23, 2019
@FRidh FRidh merged commit ad7e587 into NixOS:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbradar abbradar Awaiting requested review from abbradar

1 more reviewer

@matthewbauer matthewbauer matthewbauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@illegalprime @matthewbauer @veprbl @FRidh @GrahamcOfBorg