Skip to content

gpgme: cross compilation#58046

Merged
primeos merged 1 commit into
NixOS:masterfrom
illegalprime:gpgme-cross
Mar 22, 2019
Merged

gpgme: cross compilation#58046
primeos merged 1 commit into
NixOS:masterfrom
illegalprime:gpgme-cross

Conversation

@illegalprime
Copy link
Copy Markdown
Member

@illegalprime illegalprime commented Mar 21, 2019

Motivation for this change

Add cross compilation support for gpgme, this is important in cross-compiling NixOS itself, which I'm attempting to accomplish here: https://github.com/illegalprime/nixos-on-arm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Mar 21, 2019
@illegalprime illegalprime mentioned this pull request Mar 21, 2019
Merged
10 tasks
@primeos primeos added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Mar 22, 2019
@primeos primeos self-assigned this Mar 22, 2019
primeos
primeos approved these changes Mar 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@primeos primeos merged commit 69e23dc into NixOS:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

1 more reviewer

@primeos primeos primeos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@primeos primeos

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@illegalprime @primeos @GrahamcOfBorg