Convertibility checks now collect the auxiliary conversion data

dabrahams · dabrahams · commit 015b875a9ec0 · 2002-01-01T18:21:06.000Z
[SVN r12186]
diff --git a/src/converter/registry.cpp b/src/converter/registry.cpp
@@ -39,35 +39,6 @@ namespace registry
   {
   }
 
-  namespace // <unnamed>
-  {
-    // A UnaryFunction type which deletes its argument
-    struct delete_item
-    {
-        template <class T>
-        void operator()(T* x) const
-        {
-            delete x;
-        }
-    };
-
-    // A UnaryFunction type which returns true iff its argument is a
-    // unwrapper which can convert the given Python object.
-    struct convertible
-    {
-        convertible(PyObject* p)
-            : m_p(p)
-        {}
-        
-        bool operator()(unwrapper_base* converter) const
-        {
-            return converter->convertible(m_p);
-        }
-        
-        PyObject* m_p;
-    };
-  }
-
   entry::~entry()
   {
       if (m_wrapper != 0)
@@ -79,12 +50,25 @@ namespace registry
       }
   }
 
-  unwrapper_base* entry::unwrapper(PyObject* p) const
+  std::pair<unwrapper_base*,void*>
+  entry::unwrapper(PyObject* p) const
   {
-      unwrappers::const_iterator q =
-          std::find_if(m_unwrappers.begin(), m_unwrappers.end(), convertible(p));
+      unwrapper_base* body = 0;
+      void* data = 0;
       
-      return q == m_unwrappers.end() ? 0 : *q;
+      for (unwrappers::const_iterator q = m_unwrappers.begin(),
+               finish = m_unwrappers.end();
+           q != finish;
+           ++q)
+      {
+          data = (*q)->can_convert(p);
+          if (data != 0)
+          {
+              body = *q;
+              break;
+          }
+      }
+      return std::make_pair(body,data);
   }
   
   wrapper_base* entry::wrapper() const
diff --git a/src/converter/unwrap.cpp b/src/converter/unwrap.cpp
@@ -13,7 +13,7 @@ namespace
   struct pyobject_unwrapper : unwrapper_base
   {
       pyobject_unwrapper();
-      bool convertible(PyObject*) const;
+      void* can_convert(PyObject*) const;
   };
   
   pyobject_unwrapper static_unwrapper;
@@ -23,13 +23,13 @@ namespace
   {
   }
       
-  bool pyobject_unwrapper::convertible(PyObject*) const
+  void* pyobject_unwrapper::can_convert(PyObject*) const
   {
-      return true;
+      return non_null;
   }
 }
 
-BOOST_PYTHON_EXPORT unwrapper_base*
-unwrap_more_<PyObject*>::m_unwrapper = &static_unwrapper;
+BOOST_PYTHON_DECL std::pair<unwrapper_base*,void*>
+unwrap_more_<PyObject*>::m_unwrapper(&static_unwrapper,&static_unwrapper);
 
 }}} // namespace boost::python::converter
diff --git a/src/converter/unwrapper.cpp b/src/converter/unwrapper.cpp
@@ -21,4 +21,11 @@ unwrapper_base::~unwrapper_base()
         registry::remove(*this);
 }
 
+namespace
+{
+  int arbitrary;
+}
+
+void* const unwrapper_base::non_null = &arbitrary;
+
 }}} // namespace boost::python::converter

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ namespace`
`13`	`13`	`struct pyobject_unwrapper : unwrapper_base`
`14`	`14`	`{`
`15`	`15`	`pyobject_unwrapper();`
`16`		`- bool convertible(PyObject*) const;`
	`16`	`+ void* can_convert(PyObject*) const;`
`17`	`17`	`};`
`18`	`18`
`19`	`19`	`pyobject_unwrapper static_unwrapper;`
`@@ -23,13 +23,13 @@ namespace`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`
`26`		`- bool pyobject_unwrapper::convertible(PyObject*) const`
	`26`	`+ void* pyobject_unwrapper::can_convert(PyObject*) const`
`27`	`27`	`{`
`28`		`- return true;`
	`28`	`+ return non_null;`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`
`32`		`-BOOST_PYTHON_EXPORT unwrapper_base*`
`33`		`-unwrap_more_<PyObject*>::m_unwrapper = &static_unwrapper;`
	`32`	`+BOOST_PYTHON_DECL std::pair<unwrapper_base,void>`
	`33`	`+unwrap_more_<PyObject*>::m_unwrapper(&static_unwrapper,&static_unwrapper);`
`34`	`34`
`35`	`35`	`}}} // namespace boost::python::converter`