Netcentric · FelipeSimoes · Oct 19, 2023 · Jul 15, 2022 · Jul 21, 2022 · May 17, 2023
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
-        node-version: [16.x]
+        node-version: [18.x]
 
     steps:
       - name: Checkout
@@ -34,7 +34,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node-version: [16.x]
+        node-version: [18.x]
 
     steps:
       - name: Checkout

diff --git a/.github/workflows/manual-release.yml b/.github/workflows/manual-release.yml
@@ -24,7 +24,7 @@ env:
   GIT_COMMITTER_NAME: github-actions
   GIT_COMMITTER_EMAIL: github-actions@github.com
   CI: true
-  CONFIG_NODE_VERSION: '["16.x"]'
+  CONFIG_NODE_VERSION: '["18.x"]'
   CONFIG_OS: '["ubuntu-latest"]'
 # Main Job
 jobs:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest ]
-        node-version: [ 16.x ]
+        node-version: [ 18.x ]
 
     steps:
       - name: Checkout

diff --git a/.gitignore b/.gitignore
@@ -24,6 +24,9 @@ target/
 .DS_Store
 *.swp
 
+# git
+*.orig
+
 # Node related files
 node_modules/
 node/
@@ -50,5 +53,8 @@ dist/
 tmp/
 coverage/
 
+# coverage folder
+coverage/
+
 # Bundle Analyser
 frontend/stats.json
diff --git a/config/cache.config.js b/config/cache.config.js
@@ -0,0 +1,2 @@
+// webpack cache
+module.exports = true
diff --git a/config/devserver.config.js b/config/devserver.config.js
@@ -0,0 +1,3 @@
+module.exports = {
+
+}
diff --git a/config/eslint.config.js b/config/eslint.config.js
@@ -1,14 +1,5 @@
-// Webpack configuration
+// eslint plugin configuration
 module.exports = {
-  enforce: 'pre',
-  test: /\.js$/,
-  exclude: /node_modules/,
-  use: {
-    loader: 'eslint-loader',
-    options: {
-      cache: true,
-      failOnError: true,
-      fix: true
-    }
-  }
-};
+  failOnError: true,
+  fix: true
+};
diff --git a/config/general.config.js b/config/general.config.js
@@ -81,13 +81,13 @@ const analyzerPort = getArgumentValue('--port=') || 8888;
 const disableStyleLint = getArgumentValue('--disable-styelint');
 
 // general webpack
-const devtool = isProduction ? 'none' : 'inline-source-map';
+const devtool = isProduction ? false : 'inline-source-map';
 
 // general optimization
 const excludedFromVendors = ['babel', 'core-js'];
 
 // modules to run on webpack rules (each config module.config.js)
-const modules = ['eslint', 'babel'];
+const modules = ['babel'];
 
 // split all entries
 const multiple = true;

diff --git a/config/index.js b/config/index.js
@@ -10,6 +10,10 @@ const resolve = require('./resolve.config');
 const sass = require('./sass.config');
 const stylelint = require('./stylelint.config');
 const templates = require('./templates.config');
+const stats = require('./stats.config');
+const cache = require('./cache.config');
+const devServer = require('./devserver.config');
+const performance = require('./performance.config');
 
 const modules = general.modules;
 
@@ -26,5 +30,9 @@ module.exports = {
   stylelint,
   resolve,
   postcss,
-  templates
+  templates,
+  stats,
+  cache,
+  devServer,
+  performance
 };
diff --git a/config/optimization.config.js b/config/optimization.config.js
@@ -1,29 +1,35 @@
+const path = require('path')
 const { isProduction, excludedFromVendors } = require('./general.config');
-const moduleIsVendor = require('../utils/moduleIsVendor');
+const checkChunk = require('../utils/checkChunk');
+const nodeModules = `node_modules`;
+
+// curry to pass the module to check
+const test = ( excludes, includes) => (mod) => checkChunk(mod.context, excludes, includes);
 
 module.exports = {
   minimize: isProduction,
-  usedExports: isProduction,
+  usedExports: 'global',
   runtimeChunk: {
     name: 'commons/treeshaking.bundle.js'
   },
   splitChunks: {
+    chunks: 'initial',
+    minChunks: 2,
     cacheGroups: {
-      // Treeshake vendors in node_modules (but keep unique vendors at the clientlibs it belongs)
+    // Treeshake vendors in node_modules (but keep unique vendors at the clientlibs it belongs)
       vendors: {
-        test: mod => moduleIsVendor(mod.context, excludedFromVendors),
-        name: 'commons/vendors.bundle.js',
-        chunks: 'all',
-        // used on at least 2 modules
-        minChunks: 2
+          test: test([nodeModules], excludedFromVendors),
+          minChunks: 2,
+          enforce : true,
+          name: 'commons/vendors.bundle.js',
+          // used on at least 2 modules
       },
       // Treeshakes common imports, if used in more than 2 clientlibs
       treeshaking: {
-        test: mod => !moduleIsVendor(mod.context, excludedFromVendors),
-        name: 'commons/treeshaking.bundle.js',
-        chunks: 'all',
-        // used on at least 2 modules
-        minChunks: 2
+          test: test([nodeModules]),
+          minChunks: 2,
+          enforce : true,
+          name: 'commons/treeshaking.bundle.js',
       }
     }
   }

diff --git a/config/performance.config.js b/config/performance.config.js
@@ -0,0 +1,4 @@
+module.exports =  {
+  maxAssetSize: 100000,
+  maxEntrypointSize: 350000,
+};
diff --git a/config/plugins.config.js b/config/plugins.config.js
@@ -1,5 +1,4 @@
 const webpack = require('webpack');
-
 const { mode, analyze, analyzerPort } = require('./general.config');
 
 // pass the mode forward

diff --git a/config/stats.config.js b/config/stats.config.js
@@ -0,0 +1 @@
+module.exports = 'verbose';
diff --git a/config/stylelint.config.js b/config/stylelint.config.js
@@ -1,4 +1,4 @@
 module.exports = {
   // Stops build if a linter error is found
-  failOnError: true
+  failOnError: true,
 };
diff --git a/docs/configuration.md b/docs/configuration.md
@@ -10,17 +10,24 @@ These are the configurations that can be extended:
 
 - general
 - output
-- optimization
-- plugins
+- [optimization](https://webpack.js.org/configuration/optimization/)
+- [plugins](https://webpack.js.org/configuration/plugins/)
 - eslint
 - babel
 - sass
 - clientlibs
 - stylelint
-- resolve
+- [resolve](https://webpack.js.org/configuration/resolve/)
 - postcss
 - templates
 
+Other webpack options
+
+- [stats](https://webpack.js.org/configuration/stats/)
+- [cache](https://webpack.js.org/configuration/cache/)
+- [devServer](https://webpack.js.org/configuration/dev-server/)
+- [performance](https://webpack.js.org/configuration/performance/)
+
 ## Overriding a Default Configuration
 
 To override a configuration, add a new entry in the object exported in your `.febuild` with the name of the configuration you want to override, which value is an object whith entries that matches the existing options you want to override.
@@ -171,21 +178,8 @@ For more information about the configuration options check [eslint-loader](https
 
 ```javascript
 module.exports = {
-  {
-    eslint: {
-      enforce: 'pre',
-      test: /\.js$/,
-      exclude: /node_modules/,
-      use: {
-        loader: 'eslint-loader',
-        options: {
-          cache: true,
-          failOnError: true,
-          fix: true
-        }
-      }
-    }
-  }
+  failOnError: true,
+  fix: true // deprecated with scss only for css
 }
 ```
 

diff --git a/docs/migration.md b/docs/migration.md
@@ -1,3 +1,68 @@
+
+# Migrating to v4.0.0
+
+This release contains breaking changes. We know these can be disruptive, but they were needed to keep the dependencies updated.
+
+### using [Node 17+](https://nodejs.org/download/release/v18.18.2/)
+ breaking changes may also affect you:
+  - webpack output uses [crypto.createHash that utilize MD4 of a OpenSSL 3.0 Legacy provider]()
+
+ Those You will see this error:
+```bash
+[webpack-cli] Error: error:0308010C:digital envelope routines::unsupported
+    at new Hash (node:internal/crypto/hash:67:19)
+```
+
+#### Workaround one:
+```javascript
+
+// uses a new hash function
+// at output.config or at .febuild output property
+{
+  hashFunction: "xxhash64"
+}
+```
+#### Workaround two:
+```bash
+# At your terminal, profile or before your build function run / use
+export NODE_OPTIONS=--openssl-legacy-provider; 
+```
+
+
+### [ESlint ^8](https://eslint.org/docs/latest/use/migrate-to-8.0.0)
+Build now uses [eslint-webpack-plugin](https://www.npmjs.com/package/eslint-webpack-plugin) intead of deprecated [eslint-loader](https://www.npmjs.com/package/eslint-loader)
+It's setting the plugin now instead of loader then
+#### breaking changes 
+- review your .febuild exported eslint property to use only the [eslint options schema](https://eslint.org/docs/latest/integrate/nodejs-api#-new-eslintoptions)
+
+
+
+### [Stylelint ^15](https://stylelint.io/migration-guide/to-15/)
+
+ We recommend extending a shared configuration like [@netcentric/stylelint-config](https://github.com/Netcentric/stylelint-config) that includes the appropriate syntax to lint Scss.
+
+  Three breaking changes may also affect you:
+    - Upgrade [@netcentric/stylelint-config](https://github.com/Netcentric/stylelint-config) to  "^2.0.0",
+    - removed processors configuration property
+    - removed support for Node.js 12
+    - changed overrides.extends behavior
+
+### [Webpack ^5](https://webpack.js.org/migrate/5/) and [babel v7](https://babeljs.io/docs/v7-migration)
+
+Please review your webpack config options accordenly 
+  - Review package.json dependecies on your project to match current one
+  - review babel configs to respect [babel v7](https://babeljs.io/docs/v7-migration)
+  - review your .febuild exported properties to use webpack latest options
+    - [stats](https://webpack.js.org/configuration/stats/)
+    - [cache](https://webpack.js.org/configuration/cache/)
+    - [devServer](https://webpack.js.org/configuration/dev-server/)
+    - [performance](https://webpack.js.org/configuration/performance/)
+    - [resolve](https://webpack.js.org/configuration/resolve/)
+    - [optimization](https://webpack.js.org/configuration/optimization/)
+    - [plugins](https://webpack.js.org/configuration/plugins/)
+
+
+
 # Migrating to v2.0.0
 
 This release contains breaking changes. We know these can be disruptive, but they were needed to keep the dependencies updated.