Upgrade to webpack 5 - #73
Merged
Merged
Conversation
Contributor
|
Please wait until PR #75 is merged, it contains new test cases to test the build. |
Member
|
This looks to easy to be truth :). |
easingthemes
requested changes
Jul 22, 2022
Member
There was a problem hiding this comment.
- It should be a breaking change, since you can't know how users extended this library. Eg we are using some webpack/babel plugins by extending .febuild and we need to update (or even totally replace) them since they are not compatible with webpack v5.
- It should be tested, as @raohmaru mentioned
Member
Author
|
Leaving this unassigned since currently I don't find time to work on this. |
quicoto
approved these changes
May 17, 2023
Contributor
|
Does it contain any breaking change? If so it should be detailed in the readme. |
Member
I think so, we need to push a commit with "BREAKING CHANGE: " so the build will trigger a major release. |
FelipeSimoes
marked this pull request as draft
October 16, 2023 07:42
FelipeSimoes
marked this pull request as ready for review
October 18, 2023 17:05
easingthemes
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to webpack 5
Related Issue
Fixes #31
Types of changes
Checklist: