Skip to content

Codestyle - #25

Merged
easingthemes merged 5 commits into
mainfrom
codestyle
May 21, 2021
Merged

Codestyle#25
easingthemes merged 5 commits into
mainfrom
codestyle

Conversation

@quicoto

@quicoto quicoto commented May 21, 2021

Copy link
Copy Markdown
Member

Issues

Fixes #3
Fixes #5
Fixes #6

Types of changes

Refactor

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • [] All new and existing tests passed.

@quicoto
quicoto requested a review from easingthemes May 21, 2021 10:14
@quicoto quicoto self-assigned this May 21, 2021
@easingthemes

Copy link
Copy Markdown
Member

@quicoto commits should follow naming convention: https://github.com/Netcentric/fe-build/blob/main/docs/CONTRIBUTING.md#automated-release
So that Changelog file can be updated automatically, and also git/npm release is triggered.

Can you please at least amend last commit message.

@easingthemes easingthemes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@easingthemes
easingthemes merged commit a47eb15 into main May 21, 2021
@easingthemes
easingthemes deleted the codestyle branch May 21, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a positive statement "..." instead of "...." Order imports alphabetically

3 participants