Update our custom MPAndroid chart to be based on the official v3.1.0 release #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value is less than a configurable threshold (threshold defaults to 0.0% so text is normally always drawn). (cherry picked from commit 4a4f461)
…ays drawn. (cherry picked from commit 4b0fdfc)
(cherry picked from commit c85e212)
…n with an empty list (cherry picked from commit 79a4695)
…n CombinedChart (cherry picked from commit 8026014)
(cherry picked from commit d7e69b9)
…previous was the smallest positive float value - big difference!) (cherry picked from commit 1797983)
…y added feature is disable by default. Also, resolved a bug where check for the no data value was including values less than the no data value. Now value must be exactly the same. (cherry picked from commit 21b4acc)
Kevin-Kayes
approved these changes
Apr 3, 2025
mwfFluke
approved these changes
Apr 3, 2025
mwfFluke
left a comment
mwfFluke
left a comment
There was a problem hiding this comment.
Since this is mostly cherry-picks, I'm just going to approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://handheldnetworktools.atlassian.net/browse/AW-14504
It was previously based on the v3.1.0-alpha release. But this contour could no longer be built (see chore listed above for details).
First, I synced the master branch of the NetAlly fork with the official MPAndroidChart master branch. I then started the netally-main branch at the official v.3.1.0 contour.
And then for this PR, I cherry picked all of our NetAlly customization and modification commits (8 total) into this PR branch off of netally-main.