Skip to content

adding checks to make sure we don't cause an IndexOutOfBoundsExceptio… #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danbox merged 1 commit into from
Aug 16, 2017
Merged

adding checks to make sure we don't cause an IndexOutOfBoundsExceptio… #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MPChartLib/src/main/java/com/github/mikephil/charting/data/DataSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ public T getEntryForXValue(float xValue, float closestToY) {

@Override
public T getEntryForIndex(int index) {
// Avoid an IndexOutOfBoundsException if we try access an item outside out list
if (index >= mValues.size()) return null;
return mValues.get(index);
}

Expand Down
2 changes: 1 addition & 1 deletion MPChartLib/src/main/java/com/github/mikephil/charting/renderer/LineChartRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ public void drawValues(Canvas c) {
y - valOffset, dataSet.getValueTextColor(j / 2));
}

if (entry.getIcon() != null && dataSet.isDrawIconsEnabled()) {
if (entry != null && entry.getIcon() != null && dataSet.isDrawIconsEnabled()) {

Drawable icon = entry.getIcon();

Expand Down