Skip to content

Fixing stale files not being detected properly #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neko-Box-Coder merged 1 commit into from
Feb 24, 2025
Merged

Fixing stale files not being detected properly #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions Include/runcpp2/runcpp2.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,17 @@ namespace runcpp2

void SetLogLevel(const std::string& logLevel);

PipelineResult CheckSourcesNeedUpdate( const std::string& scriptPath,
const std::vector<Data::Profile>& profiles,
const std::string& configPreferredProfile,
const Data::ScriptInfo& scriptInfo,
const std::unordered_map< CmdOptions,
std::string>& currentOptions,
bool& outNeedsUpdate);
//NOTE: This should be run after running StartPipeline first
PipelineResult
CheckSourcesNeedUpdate( const std::string& scriptPath,
const std::vector<Data::Profile>& profiles,
const std::string& configPreferredProfile,
const Data::ScriptInfo& scriptInfo,
const std::unordered_map< CmdOptions,
std::string>& currentOptions,
const ghc::filesystem::file_time_type& prevFinalSourceWriteTime,
const ghc::filesystem::file_time_type& prevFinalIncludeWriteTime,
bool& outNeedsUpdate);

PipelineResult StartPipeline( const std::string& scriptPath,
const std::vector<Data::Profile>& profiles,
Expand All @@ -41,6 +45,8 @@ namespace runcpp2
const Data::ScriptInfo* lastScriptInfo,
const std::string& buildOutputDir,
Data::ScriptInfo& outScriptInfo,
ghc::filesystem::file_time_type& outFinalSourceWriteTime,
ghc::filesystem::file_time_type& outFinalIncludeWriteTime,
int& returnStatus);

std::string PipelineResultToString(PipelineResult result);
Expand Down
11 changes: 11 additions & 0 deletions Src/runcpp2/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,8 @@ int main(int argc, char* argv[])
}

runcpp2::Data::ScriptInfo* lastParsedScriptInfo = nullptr;
ghc::filesystem::file_time_type lastFinalSourceWriteTime;
ghc::filesystem::file_time_type lastFinalIncludeWriteTime;
bool needsRunning = true; //First run always needs running

while(true)
Expand All @@ -439,6 +441,8 @@ int main(int argc, char* argv[])
*lastParsedScriptInfo :
parsedScriptInfo,
currentOptions,
lastFinalSourceWriteTime,
lastFinalIncludeWriteTime,
needsUpdate) != runcpp2::PipelineResult::SUCCESS)
{
ssLOG_ERROR("Failed to check if sources need update");
Expand Down Expand Up @@ -477,6 +481,8 @@ int main(int argc, char* argv[])
lastParsedScriptInfo,
"",
parsedScriptInfo,
lastFinalSourceWriteTime,
lastFinalIncludeWriteTime,
result);

static_assert(static_cast<int>(runcpp2::PipelineResult::COUNT) == 13, "Update this");
Expand Down Expand Up @@ -518,6 +524,9 @@ int main(int argc, char* argv[])
if(currentOptions.count(runcpp2::CmdOptions::BUILD) > 0)
outputDir = ghc::filesystem::current_path().string();

ghc::filesystem::file_time_type finalSourceWriteTime;
ghc::filesystem::file_time_type finalIncludeWriteTime;

if(runcpp2::StartPipeline( script,
profiles,
preferredProfile,
Expand All @@ -526,6 +535,8 @@ int main(int argc, char* argv[])
nullptr,
outputDir,
parsedScriptInfo,
finalSourceWriteTime,
finalIncludeWriteTime,
result) != runcpp2::PipelineResult::SUCCESS)
{
return -1;
Expand Down
Loading