Skip to content

Fix Firebase Deploy CI failure caused by Node.js 20 deprecation #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AchoArnold merged 2 commits into from
Jun 25, 2026
Merged

Fix Firebase Deploy CI failure caused by Node.js 20 deprecation #929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eac64c5
Initial plan
Copilot Jun 25, 2026
95fe89c
Fix Firebase Deploy CI failure: pin action-hosting-deploy to Node 24-…
Copilot Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/web.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
gitHubToken: ${{ secrets.GITHUB_TOKEN }}

- name: Firebase Deploy 🚀
uses: FirebaseExtended/action-hosting-deploy@v0
uses: FirebaseExtended/action-hosting-deploy@500ac625ca2dd40cbd15f7659af953801858032a

@greptile-apps greptile-apps Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Pin comment missing for maintenance tracking

The SHA 500ac625... is pinned because no release tag includes the Node 24 runtime fix, but there is no inline comment explaining this. When a proper release tag is eventually cut, the next engineer will have no context for why a bare commit hash is here instead of @v0 or @v1, making it easy to accidentally "clean up" the pin back to a broken tag. A brief # TODO: replace with release tag once v0.11+ is cut comment would make the intent self-documenting.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

with:
repoToken: "${{ secrets.GITHUB_TOKEN }}"
channelId: live
Expand Down