Select which SIM to use to send messages - #133
Conversation
* commit '19c0d48f468dcc1746330dbc05d9ed7dc240244f': emove unused router page
* commit 'ca94a6a1e121f1ce27dbcae5be3c99492e54610f': Set APP_HOST as empty Add more API keys Update depdendencies to latest version
…lt SIM card if it's not explicitly defined.
|
Hello @eriksson Thanks for your PR this is some awesome work 👍 If you don't have the time to fix the issues which I mentioned, ping me and I can fix the issues myself. |
Hi @AchoArnold I cannot see where are the issues you mentioned. Please, can you add them as comments to this pull request? I'll address them as soon as possible. |
I didn't make the review comments public, I've done that now. |
|
Thanks @AchoArnold . Now I can see your reviews. I'll address them. |
* handle_local_event_queue: refactor code and create a local implementation of the PushQueue interface: InMemoryPushQueue
* handle_local_event_queue: add missing span.End()
* handle_local_event_queue: add missing span.End()
* message_sim_card: refactor: empty string check use SIM1 and SIM2 instead of ISMS and ISMS2
* commit '48f9b0a4862e1699079666181991d7c21b53f89a': Add webhook restriction Updte all packages Fix the loading of messages on send Reduce timeout to 30 seconds Refactor in memory push queue to emulator push queue chore(deps-dev): bump @babel/eslint-parser from 7.19.1 to 7.21.3 in /web chore(deps-dev): bump @nuxt/types from 2.16.0 to 2.16.3 in /web fix(deps): bump libphonenumber-js from 1.10.21 to 1.10.24 in /web fix(deps): bump nuxt from 2.16.2 to 2.16.3 in /web fix(deps): bump webpack from 5.76.1 to 5.76.2 in /web fix(deps): bump firebase from 9.17.2 to 9.18.0 in /web fix(deps): bump @mdi/js from 7.1.96 to 7.2.96 in /web fix(deps): bump core-js from 3.29.0 to 3.29.1 in /web fix(deps): bump actions/cache from 3.3.0 to 3.3.1
…nvironment." This reverts commit 95f3f52.
…and add authentication and content type headers to the request
…sim_card * commit '0f3bd6348dad06fe72a743c0c8ad9cc36a2ce26a': Use popup flow instead of redirect Fix sign in flow
|
Hello @eriksson |
hey @AchoArnold I sent you a request 2 days ago. |
|
Great Work @eriksson |

This PR implements the support to select which SIM card to use to deliver a message #130