Skip to content

Select which SIM to use to send messages - #133

Merged
AchoArnold merged 25 commits into
NdoleStudio:mainfrom
eriksson:message_sim_card
Mar 29, 2023
Merged

Select which SIM to use to send messages#133
AchoArnold merged 25 commits into
NdoleStudio:mainfrom
eriksson:message_sim_card

Conversation

@eriksson

Copy link
Copy Markdown
Contributor

This PR implements the support to select which SIM card to use to deliver a message #130

@AchoArnold

Copy link
Copy Markdown
Member

Hello @eriksson

Thanks for your PR this is some awesome work 👍

If you don't have the time to fix the issues which I mentioned, ping me and I can fix the issues myself.

@eriksson

Copy link
Copy Markdown
Contributor Author

Hello @eriksson

Thanks for your PR this is some awesome work 👍

If you don't have the time to fix the issues which I mentioned, ping me and I can fix the issues myself.

Hi @AchoArnold I cannot see where are the issues you mentioned. Please, can you add them as comments to this pull request? I'll address them as soon as possible.

Comment thread api/pkg/services/event_dispatcher_service.go Outdated
Comment thread api/pkg/entities/message.go Outdated
Comment thread api/pkg/requests/message_bulk_send_request.go Outdated
Comment thread android/app/src/main/java/com/httpsms/LoginActivity.kt Outdated
Comment thread android/app/src/main/res/xml/network_security_config.xml Outdated
Comment thread web/pages/threads/_id/index.vue Outdated
@AchoArnold

Copy link
Copy Markdown
Member

Hi @AchoArnold I cannot see where are the issues you mentioned. Please, can you add them as comments to this pull request? I'll address them as soon as possible.

I didn't make the review comments public, I've done that now.

@eriksson

Copy link
Copy Markdown
Contributor Author

Thanks @AchoArnold . Now I can see your reviews. I'll address them.

eriksson added 17 commits March 19, 2023 22:00
* handle_local_event_queue:
  refactor code and create a local implementation of the PushQueue interface: InMemoryPushQueue
* handle_local_event_queue:
  add missing span.End()
* handle_local_event_queue:
  add missing span.End()
* message_sim_card:
  refactor: empty string check
  use SIM1 and SIM2 instead of ISMS and ISMS2
* commit '48f9b0a4862e1699079666181991d7c21b53f89a':
  Add webhook restriction
  Updte all packages
  Fix the loading of messages on send
  Reduce timeout to 30 seconds
  Refactor in memory push queue to emulator push queue
  chore(deps-dev): bump @babel/eslint-parser from 7.19.1 to 7.21.3 in /web
  chore(deps-dev): bump @nuxt/types from 2.16.0 to 2.16.3 in /web
  fix(deps): bump libphonenumber-js from 1.10.21 to 1.10.24 in /web
  fix(deps): bump nuxt from 2.16.2 to 2.16.3 in /web
  fix(deps): bump webpack from 5.76.1 to 5.76.2 in /web
  fix(deps): bump firebase from 9.17.2 to 9.18.0 in /web
  fix(deps): bump @mdi/js from 7.1.96 to 7.2.96 in /web
  fix(deps): bump core-js from 3.29.0 to 3.29.1 in /web
  fix(deps): bump actions/cache from 3.3.0 to 3.3.1
…and add authentication and content type headers to the request
…sim_card

* commit '0f3bd6348dad06fe72a743c0c8ad9cc36a2ce26a':
  Use popup flow instead of redirect
  Fix sign in flow
@eriksson
eriksson requested a review from AchoArnold March 26, 2023 20:04
@AchoArnold

Copy link
Copy Markdown
Member

Hello @eriksson
Ping me when this is ready to be reviewed again.
Thanks

@eriksson

Copy link
Copy Markdown
Contributor Author

Hello @eriksson Ping me when this is ready to be reviewed again. Thanks

hey @AchoArnold I sent you a request 2 days ago.
maybe you didn't get notified

image

@AchoArnold

Copy link
Copy Markdown
Member

Great Work @eriksson

@AchoArnold AchoArnold closed this Mar 29, 2023
@AchoArnold AchoArnold reopened this Mar 29, 2023
@AchoArnold
AchoArnold merged commit 91ea5c1 into NdoleStudio:main Mar 29, 2023
@eriksson
eriksson deleted the message_sim_card branch March 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants