Repository navigation
fix(windows-v8): pump the V8 platform's foreground tasks - #51
Merged
Merged
Conversation
FinalizationRegistry cleanup, GC finalization and the memory reducer post foreground tasks to the platform, which the standalone event loop never ran. The drain hook now pumps the platform after the microtask checkpoint. Adds packages/test/finalization-check.js.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone windows-v8 runtime never pumped V8's platform, so foreground tasks (FinalizationRegistry cleanup, GC finalization, the memory reducer) never ran.
platform::initializekeeps the platform for the process;platform::pumpruns the isolate's queued tasks.js_get_isolatein the shim exposes the isolate to Rust.Test:
nativescript-windows packages/test/finalization-check.jsprintsfinalization-check: PASS.