feature: Add groups created by addPbxGroup() to the meta PBXGroup #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Fatme
reviewed
May 9, 2018
| f = util.format, | ||
| EventEmitter = require('events').EventEmitter, | ||
| path = require('path'), | ||
| $path = require('path'), |
There was a problem hiding this comment.
I'm wondering why we are using $ before path.
Author
There was a problem hiding this comment.
We need to differentiate between the global (used for path module) and local (passed in most of the methods) variable.
lib/pbxProject.js
Outdated
| pbxProject.prototype.addPbxGroup = function (filePathsArray, name, path, sourceTree, opt) { | ||
| var groups = this.hash.project.objects['PBXGroup'], | ||
| pbxGroupUuid = this.generateUuid(), | ||
| pbxGroupUuid = opt.uuid ? opt.uuid : this.generateUuid(), |
There was a problem hiding this comment.
opt.uuid || this.generateUuid() is shorter
lib/pbxProject.js
Outdated
| var groups = this.hash.project.objects['PBXGroup']; | ||
| var candidates = []; | ||
| for (var key in groups) { | ||
| if (groups[key].path == undefined && groups[key].name == undefined && groups[key].isa) { |
There was a problem hiding this comment.
Maybe this is better
if (groups[key] && !groups[key].path && !groups[key].name && groups[key].isa) { .. }
| return candidates[0]; | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
In case when we have more than one candidate, shouldn't return the first one? Actually is it possible to have more than one candidate?
Author
There was a problem hiding this comment.
We should have exactly one candidate as this will be the root group. If they are more than one there should be an error. Maybe we can throw an exception.
tdermendjiev
force-pushed
the
tdermendzhiev/fix-addpbxgroup
branch
2 times, most recently
from
d86b18b to
23214db
Compare
mbektchiev
force-pushed
the
tdermendzhiev/fix-addpbxgroup
branch
3 times, most recently
from
a929177 to
733e10a
Compare
*support for c++ files added *recursively add pbxGroup and its children *recursively remove pbxGroup and its children *make sure pbx group name is not duplicated on adding new group
tdermendjiev
force-pushed
the
tdermendzhiev/fix-addpbxgroup
branch
from
cc0ac78 to
f1b6a8c
Compare
Fatme
reviewed
May 21, 2018
lib/pbxFile.js
Outdated
|
|
||
| function fileTypes() { | ||
| return { | ||
| SOURCE_FILE, |
Fatme
reviewed
May 21, 2018
lib/pbxProject.js
Outdated
| } | ||
|
|
||
| pbxProject.prototype.removePbxGroup = function(name, path) { | ||
| var group = this.pbxGroupByName(name); |
tdermendjiev
force-pushed
the
tdermendzhiev/fix-addpbxgroup
branch
from
fd2171a to
93cb011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't add created groups to the main/meta PBXGroup and therefore they don't show up in the file tree.