Skip to content

Conversation

@e2l3n
Copy link

@e2l3n e2l3n commented Aug 31, 2015

Rebase origin (https://github.com/alunny/node-xcode) onto current master so that we have the latest changes from upstream.

BBosman and others added 24 commits August 31, 2015 17:40
…to remove its given file from PBXFileReference.
Adding COMPILER_FLAGS with = or space corrupts the project file and it can not be parsed by xcode or xcodebuild
I tested how xcode behaves and it adds quotes around the COMPILER_FLAGS setting, but it doesn't add quotes to Weak from ATTRIBUTES.
This is the reason this fix is applied only when opt.compilerFlags is present
Xcode handles this correctly and some tools might produce such projects.
… trailing comma

In our testing, we've hit projects where trailing commas are not present with array entries.
By given array of files add a build phase which includes the given files.
All files should be added to PBXBuildFileSection as well as to the PBXFileReferenceSection
Upon adding a build phase an unnecessary property is added, namely uuid
For given file paths add them to Build and File Reference sections if they're not already added and create a PBXGroup with given name, path and optional sourceTree.
sourceTree defaults to <group> if no other specified
By given configuration objects, default configuration name and a comment add all configurations to PBXXCBuildConfigurationSection and add an XCConfigurationList
This way new knownRegions, TargetAttributes and targets can be added
Add a check - if a file exists in the PBXBuildFile and the PBXFileReference sections do not add it
Includes a bit of refactoring and extracting common logic between pbxGroupByName and pbxTargetByName into the more powerful function pbxItemByComment.
This enables greater customization when adding file to FileReference Section, like for example adding build output files (e.g. .app files or .appex files)
Includes creation of a PBXContainerItemProxy for each PBXTargetDependency and including the PBXTargetDependencies to the given target
e2l3n referenced this pull request in NativeScript/nativescript-cli Sep 2, 2015
@Mitko-Kerezov
Copy link

👍

@Mitko-Kerezov
Copy link

Ping @Fatme

@Fatme
Copy link

Fatme commented Sep 3, 2015

👍

e2l3n added a commit that referenced this pull request Sep 8, 2015
@e2l3n e2l3n merged commit 08846bb into NativeScript:master Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants