Fix quotes and lastKnownFileType#1
Merged
Merged
Conversation
Fix quotes
|
👍 |
Fatme
pushed a commit
that referenced
this pull request
Jun 25, 2015
Fix quotes and lastKnownFileType
KristianDD
pushed a commit
that referenced
this pull request
Jan 30, 2019
merge latest updates into mcgrews3-fork
KristianDD
pushed a commit
that referenced
this pull request
Jan 30, 2019
The method `project.removeFromFrameworksPbxGroup` directly tries to access `children` on `project.pbxGroupByName` - but this method might return `null` if no such group exists. To prevent a runtime error when trying to access a property on `null` we can add a check whether the requested group "Frameworks" does exist in the project and only then continue with the removal of the file. This closes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem1 - Quotes
Quotes are added every time when pbxFileReferenceObj function is called. But we need them only when the file contains special characters. If the file doesn't contain special characters and
removeResourceFilefunction is called, the resource was successfully removed frompbxBuildFileSection. But the file reference is not removed frompbxFileReferenceSection. This happens because the reference inpbxprojectfile doesn't contain quotes but we add the quotes and do incorrect comparison.Problem2 - Unknown lastKnownFileType
addResourceFilefunction setslastKnownFileTypeproperty of file tounknowninPBXFileReferencesection. This PR fixes the type only .png image is added as resource.