Skip to content

fix: print messages from hooks only with --log trace #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosen-vladimirov merged 1 commit into from
Feb 28, 2019
Merged

fix: print messages from hooks only with --log trace #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/before-prepare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ module.exports = function ($logger, $projectData, $usbLiveSyncService) {
var liveSync = $usbLiveSyncService.isInitialized;
var bundle = $projectData.$options.bundle;
if (liveSync || bundle) {
$logger.warn("Hook skipped because either bundling or livesync is in progress.")
$logger.trace("Hook skipped because either bundling or livesync is in progress.")
return;
}

return converter.convert($logger, $projectData.projectDir, $projectData.appDirectoryPath, $projectData.appResourcesDirectoryPath);
}
4 changes: 2 additions & 2 deletions src/lib/compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ function compile(data) {
return new Promise((res, rej) => {
var projectDir = data.projectDir,
appDir = data.appDir;

var logger = new LogProvider(data.logger);

var sassPath = require.resolve('node-sass/bin/node-sass');
if (fs.existsSync(sassPath)) {
logger.info("Found peer node-sass");
logger.trace("Found peer node-sass");
} else {
isResolved = true;
rej(new Error('node-sass installation local to project was not found. Install by executing `npm install node-sass`.'));
Expand Down
2 changes: 1 addition & 1 deletion src/lib/watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = function (logger, projectData, usbLiveSyncService, hookArgs) {
if (hookArgs.config) {
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
if (appFilesUpdaterOptions.bundle) {
logger.warn("Hook skipped because bundling is in progress.")
logger.trace("Hook skipped because bundling is in progress.")
return;
}
}
Expand Down