Repository navigation
Mivanova/nsconfig projects - #141
Merged
Merged
Conversation
miroslavaivanova
commented
Jun 7, 2018
miroslavaivanova
commented
Contributor
- add tests for device debug ios/android
- change create of nsconfig tests NG, added webpack, sass and typecsript
dtopuzov
reviewed
Jun 7, 2018
| from core.tns.tns_platform_type import Platform | ||
| from core.osutils.command import run | ||
|
|
||
| class DebugBothPlatformsTests(BaseClass): |
Contributor
There was a problem hiding this comment.
PEP8 require 2 blank lines between imports and class DebugBothPlatformsTests(BaseClass):
dtopuzov
reviewed
Jun 7, 2018
| Npm.uninstall(package="nativescript-dev-sass", option='--save-dev', folder=app_name_change_app_location_ng) | ||
| Npm.install(package=SASS_PACKAGE, option='--save-dev', folder=app_name_change_app_location_ng) | ||
| File.remove(TEST_RUN_HOME + "/" + app_name_change_app_location_ng + "/" | ||
| + "node_modules/.bin/babylon") |
Contributor
There was a problem hiding this comment.
PEP8 warning for visual indent, can be fixed by auto formatting shortcuts.
dtopuzov
reviewed
Jun 7, 2018
| Npm.uninstall(package="nativescript-dev-sass", option='--save-dev', folder=app_name_change_app_location_ls_ng) | ||
| Npm.install(package=SASS_PACKAGE, option='--save-dev', folder=app_name_change_app_location_ls_ng) | ||
| File.remove(TEST_RUN_HOME + "/" + app_name_change_app_location_ls_ng + "/" | ||
| + "node_modules/.bin/babylon") |
Contributor
There was a problem hiding this comment.
PEP8 warning for visual indent, can be fixed by auto formatting shortcuts.
dtopuzov
approved these changes
Jun 7, 2018
dtopuzov
left a comment
dtopuzov
left a comment
Contributor
There was a problem hiding this comment.
Approve after fixing PEP8 styling.
Looks fine for now.
Ideas for future improvements (not required to be in same PR):
- Debug device and emulator/simualators tests are almost the same code, we should see how we can reuse it.
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 19, 2018
* added new tests for debug ios and android * modified NG config tests
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 28, 2018
* added new tests for debug ios and android * modified NG config tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.