Repository navigation
add test form resource generate icon which not generate by xcode - #140
Merged
Merged
Conversation
dtopuzov
approved these changes
Jun 7, 2018
dtopuzov
approved these changes
Jun 7, 2018
dtopuzov
left a comment
dtopuzov
left a comment
Contributor
There was a problem hiding this comment.
Approve after fixing PEP8 warning.
| ResourcesGenerateTests.check_splashes(app_resources_android, app_resources_ios) | ||
|
|
||
| def test_003_tns_resources_generate_icons_apetools(self): | ||
| #https://github.com/NativeScript/nativescript-cli/issues/3666 |
Contributor
There was a problem hiding this comment.
PEP8 require space between # and https://github.com/NativeScript/nativescript-cli/issues/3666
| 'AppIcon.appiconset')) | ||
| folder = os.path.join(TEST_RUN_HOME, "data", "images", "resources_generate", "apetool", | ||
| "AppIcon.appiconset") | ||
| destination = os.path.join(self.app_name, 'app', 'App_Resources', 'iOS', 'Assets.xcassets', 'AppIcon.appiconset') |
| from core.base_class.BaseClass import BaseClass | ||
| from core.osutils.command import run | ||
| from core.osutils.folder import Folder | ||
| from core.osutils.file import File |
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 19, 2018
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unable to generate icons when the Contents.json is not generated by Xcode.
Test for NativeScript/nativescript-cli#3666