Repository navigation
fix: test for Google Analytics message - cli#3536 - #114
Merged
Natalia-Hristova merged 3 commits intoJun 7, 2018
Merged
Conversation
dtopuzov
reviewed
May 10, 2018
| Tns.create_app(self.app_name, update_modules=False) | ||
|
|
||
| # Disable tracking in Google Analytics https://github.com/NativeScript/nativescript-cli/issues/3536 | ||
| Tns.run_tns_command("usage-reporting disable") |
Contributor
There was a problem hiding this comment.
I think we disable usage reporting before all tests.
Not sure what will happen if it is disabled and we disable it again (it might be ok, just need to check it).
Here we do some enable/disable:
https://github.com/NativeScript/nativescript-cli-tests/blob/master/tests/build/common/usage_reporting_tests.py
May be we can move/extend tests there (all tests in UsageReportingTests class are specially for this feature).
Contributor
|
May be we can also add test for this specific case: |
Author
|
Move the test for issue nativescript-cli#3536 in |
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 19, 2018
* fix: test for Google Analytics message - cli#3536 * fix: Move tests. * add test for local paths in Analytics
Natalia-Hristova
pushed a commit
that referenced
this pull request
Jun 28, 2018
* fix: test for Google Analytics message - cli#3536 * fix: Move tests. * add test for local paths in Analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for issue: NativeScript/nativescript-cli#3536
Note: PR should be merged after the fix is in master a.k.a naticescript-cli release is merged into master.