Skip to content

Allow seperate requests for Camera & Photos perms#176

Closed
DanielDent wants to merge 2 commits intoNativeScript:masterfrom
DanielDent:master
Closed

Allow seperate requests for Camera & Photos perms#176
DanielDent wants to merge 2 commits intoNativeScript:masterfrom
DanielDent:master

Conversation

@DanielDent
Copy link

@DanielDent DanielDent commented Mar 9, 2019

In some use cases, permission for the camera is all that's needed. This change allows people to request either permission individually.

@cla-bot
Copy link

cla-bot bot commented Mar 9, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @DanielDent.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@ghost ghost added the new PR label Mar 9, 2019
@cla-bot cla-bot bot removed the new PR label Mar 9, 2019
@DanielDent
Copy link
Author

DanielDent commented Mar 10, 2019

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Mar 10, 2019

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label Mar 10, 2019
@tgpetrov
Copy link
Contributor

tgpetrov commented Mar 14, 2019

Hi @DanielDent
Thank you for your contribution.
Could you also mention the newly exposed methods in the README.md file?

@DanielDent
Document split permission request functions
73c9fd4 
The requestPermissions function remains available for requesting camera and saved photos access with a single function call, while requestCameraPermissions and
requestPhotosPermissions have been added to allow each permission to be requested on its own.
@ghost ghost added the new PR label Mar 17, 2019
@DimitarTodorov
Copy link
Contributor

DimitarTodorov commented Mar 18, 2019

Hi @DanielDent
Since the PR is made from fork, the CI checks would not pass. I've created the same PR in our repo in order to run the CI checks in travis. Once the tests pass, we will merge the PR.

Thanks again for the contribution,
NativeScript Team

@ghost ghost removed the new PR label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielDent @tgpetrov @DimitarTodorov