Repository navigation
Not all modules from @nativescript/angular are exported to nativescript-angular #2059
Description
Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):
- CLI: 6.2.0
- Cross-platform modules: 6.2.0
- Android Runtime: 6.2.0
- iOS Runtime: 6.2.0
- Plugin(s):
- NativeScript-Angular: 8.20.1-rc-2019-11-08-175723-01
- Angular: 8.2.0
Describe the bug
Modules like @nativescript/angular/app-host-view, @nativescript/angular/common/detached-loader, and @nativescript/angular/common/utils are not exported to nativescript-angular, this causes backwards incompatibility with some plugins.
To Reproduce
require("nativescript-angular/common/utils");
Causes the following error:
Module not found: Error: Can't resolve 'nativescript-angular/common/utils'
Expected behavior
nativescript-angular should export all modules from @nativescript/angular to keep backward compatibility.
Sample project
Additional context
Reacted by atchaiecommerce and felixelgato92
Activity
tbozhikov commentedon Nov 12, 2019
Hi @mukaschultze, thanks for reporting this. We are preparing a patch addressing this breaking change. Meanwhile, could you please share the plugins you've found broken by this? Thanks!
mukaschultze commentedon Nov 12, 2019
@tbozhikov
nativescript-material-bottomsheetis the only plugin I've found to be broken so faratchaiecommerce commentedon Nov 13, 2019
nativescript-masked-textfield is also broken. it looks for nativescript-angular/forms/value-accessors/text-value-accessor which is missing from nativescript-angular package.
NickIliev commentedon Dec 13, 2019
The Jasmine import is also to be corrected.
fix: wrong import path in compat package