feat(android): add "Don't keep activities" functionality #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
reviewed
Feb 27, 2018
lib/android-controller.ts
Outdated
|
|
||
| public static setDontKeepActivities(value: boolean, device: IDevice) { | ||
| let status: 0 | 1; | ||
| value ? status = 1 : status = 0; |
lib/android-controller.ts
Outdated
| value ? status = 1 : status = 0; | ||
|
|
||
| const prefix = AndroidController.gettokenPrefix(device.type); | ||
| executeCommand(AndroidController.ADB + ` -s ${prefix}${device.token} shell service call activity 43 i32 ${status}`); |
There was a problem hiding this comment.
`${AndroidController.ADB} -s ${prefix}${device.token} shell service call activity 43 i32 ${status}`
lib/android-controller.ts
Outdated
| executeCommand(AndroidController.ADB + ` -s ${prefix}${device.token} shell service call activity 43 i32 ${status}`); | ||
|
|
||
| if (this.getAlwaysFinishActivitiesGlobalSettingsValue(device) !== value) { | ||
| throw new Error(`Failed to set \"Don't keep activities\" to ${value}!`); |
There was a problem hiding this comment.
You don't need to escape the quotes when using backticks (`).
lib/android-controller.ts
Outdated
|
|
||
| private static getAlwaysFinishActivitiesGlobalSettingsValue(device: IDevice): boolean { | ||
| const prefix = AndroidController.gettokenPrefix(device.type); | ||
| return executeCommand(AndroidController.ADB + " -s " + `${prefix}${device.token}` + " shell settings get global always_finish_activities").trim() === "1"; |
There was a problem hiding this comment.
You can move the command to a variable.
Also you can move the result of the execution to a variable.
AndroidController.ADB + " -s " + `${prefix}${device.token}` + " shell settings get global always_finish_activities"
-->
`${AndroidController.ADB} -s ${prefix}${device.token} shell settings get global always_finish_activities`
This allows you to turn on/off "Don't keep activities" setting in the Developer options for Android.
vchimev
force-pushed
the
vchimev/dont-keep-activities
branch
from
fcb961c to
4649708
Compare
vchimev
changed the title
Contributor
Author
|
Ping @sis0k0 and @SvetoslavTsenov. |
vchimev
force-pushed
the
vchimev/dont-keep-activities
branch
from
d2c3508 to
d64efd1
Compare
SvetoslavTsenov
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to turn on/off "Don't keep activities" setting in the Developer options for Android.