Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NativeScript/ios-device-lib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: NativeScript/ios-device-lib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: vladimirov/handle-errors
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 3, 2019

  1. fix: handle errors when ios-device-lib process exits 

    In case the ios-device-lib process fails or is unable to start, we do not receive any information. In this case throw an error, so the caller can understand there's a problem.
    @rosen-vladimirov
    rosen-vladimirov committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    8dcb39e View commit details
    Browse the repository at this point in the history

  2. fix: stringify messages passed to ios-device-lib binary correctly 

    The ios-device-lib binary can work only with string types of data, but currently we pass booleans, numbers, etc. Handle this directly in the stringification by returning the stringified version of the primitive types.
    @rosen-vladimirov
    rosen-vladimirov committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    215457b View commit details
    Browse the repository at this point in the history
Loading