Support new gradle dependency configurations #993

Activity

1. NickIliev

   added

   feature

   os: android

   on Apr 3, 2018
2. petekanev

   assigned

   petekanev

   and

   Plamen5kov

   on Apr 3, 2018
3. Plamen5kov commented on Apr 3, 2018

   

   Plamen5kov

   on Apr 3, 2018

   Contributor

   More actions

   @NickIliev
   After a bit of research here are my findings:
   How did we manage up until now to get the compile dependencies resolved by gradle?
   Basically, we got the resolved dependencies at build time which were resolved by the build system.

   Why can't we do that with implementation and api?
   After a bit of tinkering:

   configurations.all.each({ item ->
      if(item.name.equals("implementation")) {
         println item.resolvedConfiguration
      }
   })
   

   I reached this error: Resolving configuration 'implementation' directly is not allowed, which is pretty self-explanatory.

   Unfortunately for us, gradle resolves it's implementation dependencies lazily and I couldn't find the API to find the implementation and api defined project dependencies.

   A possible workaround would be to ask the users and plugin authors to continue using compile instead of implementation and api at least until we figure a way to solve the problem.
4. petekanev commented on Apr 4, 2018

   

   petekanev

   on Apr 4, 2018

   Last edited by petekanev

   Contributor

   More actions

   @Plamen5kov @NickIliev I'd like to add that after tinkering on my part, configurations.{depsType} (debugCompile, api, runtimeOnly, etc.) are also inaccessible beyond what we are already using configurations.compile. As a matter of fact, if you inspect the type of the configurations container, you won't find the properties on the object.

   Another thing to note:

   debugCompile dependencies weren't being exploded either, as we'd only explode the compile dependencies. This means that you aren't able to access debug compile dependencies in JavaScript.
5. Plamen5kov

   removed their assignment

   on Apr 4, 2018
6. darind

   added this to the 4.1.0This milestone has been deleted milestone on Apr 30, 2018
7. darind

   unassigned

   petekanev

   on Apr 30, 2018
8. darind

   added

   ready for test

   on Apr 30, 2018
9. Natalia-Hristova

   self-assigned this

   on May 10, 2018
10. vhristov5555

    unassigned

    Natalia-Hristova

    on May 17, 2018
11. vhristov5555

    added

    testing

    and removed

    ready for test

    on May 21, 2018
12. vhristov5555

    self-assigned this

    on May 21, 2018
13. vhristov5555

    added

    ready for release

    and removed

    testing

    on May 23, 2018
14. vhristov5555

    added a commit that references this issue on May 29, 2018

    Add tests for NativeScript/android#993. Also improve interface tests …

    ...

    0b25b3f
15. vhristov5555

    closed this as completedon May 31, 2018
16. vhristov5555

    removed

    ready for release

    on May 31, 2018
17. vhristov5555

    added a commit that references this issue on Jun 12, 2018

    Add implements api compile tests (#136)

    ...

    d67f37f
18. Natalia-Hristova

    added a commit that references this issue on Jun 19, 2018

    Add implements api compile tests (#136)

    ...

    4a984b1
19. Natalia-Hristova

    added a commit that references this issue on Jun 28, 2018

    Add implements api compile tests (#136)

    ...

    1f1f3f5