Skip to content

Tracking issue for dirty (mixed) build failures #759

Closed
NativeScript/nativescript-dev-webpack
#153

Description

@NickIliev

From @ishitatsuyuki on May 5, 2017 11:10

This is the tracking issue for gradlew failure on :asbg:generateBindings.

Workaround found:

rm platforms/android/build-tools/android-static-binding-generator/*.txt

The aim of this issue is to resolve the root cause of the problem. The check of duplicate entries was introduced in 53cc589.

Copied from original issue: NativeScript/nativescript-dev-webpack#145

Activity

  1. ishitatsuyuki commented on May 26, 2017

    @ishitatsuyuki
    Contributor
  2. reopened this on May 26, 2017
  3. self-assigned this
    on May 26, 2017
  4. ishitatsuyuki commented on May 27, 2017

    @ishitatsuyuki
    Contributor

    Gotcha, removing the dirty bindings.txt will solve this problem. The easiest way to do this is adding fs.unlinkSync(outFile) to https://github.com/NativeScript/android-runtime/blob/40dd832/android-static-binding-generator/project/parser/js_parser.js#L74.

    I believe this make incremental compilation act as intended (less rebuild than before), but I'm not confident (no easy way to test and prove it).
    Also, unlinkSync doesn't look very well, there should be some refactor such as opening the file with truncation flag, and store it's fd as global variable (PS: don't forget to close it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions