Repository navigation
fix(ios): additional safe area insets were miscalculated if already set - #9991
Merged
NathanWalker merged 2 commits intoAug 10, 2022
Merged
Conversation
CatchABus
marked this pull request as draft
August 10, 2022 15:49
Contributor
|
I've tested this solution in different apps using iOS simulators: iphone 8, 12 and 13 and 13 Pro and it's working properly. I did a lot of stress test and could not reproduce the issue again. The unit tests are all passing. |
CatchABus
marked this pull request as ready for review
August 10, 2022 20:56
NathanWalker
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
During additional safe area inset calculation, view controllers also included the old additional safe area inset values. Subtracting them from
currentInsetsTopandcurrentInsetsTophelps calculate proper values for additional insets and fixes problems like tabs infinite loop during rotation.See #9931 for more details by @dgmachado. He has provided a sample and precious information.
What is the new behavior?
Application will properly calculate insets and operate normally after rotation without problems.
Fixes #9931 #8339