Repository navigation
fix(ios): app stopped responding after screen rotation - #9986
Merged
NathanWalker merged 1 commit intoAug 8, 2022
Merged
Conversation
Contributor
|
I've tested this solution in different apps using iOS simulators: iphone 8, 12 and 13 and it's working properly. I did a lot of stress test and could not reproduce the issue again. |
NathanWalker
approved these changes
Aug 8, 2022
Contributor
|
@CatchABus this appears to cause quite a number of failed e2e tests: |
Contributor
|
You can run them locally with: |
Contributor
Author
My bad... I'll make sure to look into this as soon as possible! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The iOS app isn't responding after rotation. The issue is only reproducible on the iOS phone. Cannot be reproduced on an iOS tablet.
The issue can be reproduced immediately (after the first rotation) on the nested tabs scenario.
See #9931 for more details by @dgmachado. He has provided a sample and precious information.
If needed, NS view controllers will modify their own insets when they layout subviews. This seemed to cause problems in a rotation scenario due to wrong checks inside core during children insets calculation.
What is the new behavior?
Application will operate normally after rotation without problems.
Fixes #9931