Repository navigation
fix(core): FormattedString.spans threw error in markup. - #9960
Merged
Merged
Conversation
Collaborator
|
@CatchABus using for let is known to be slower than classing for loop. Actually nothing is faster than classic for loop. Could we stick to it? |
Contributor
Author
|
@farfromrefug Done! |
NathanWalker
approved these changes
Jul 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Span items throw
is not a valid View instancemarkup error. This is related to few ObservableArray changes in 8.3.What is the new behavior?
Span items will render without problems.