Repository navigation
fix(core): iOS app memory leak after using 'showModal' passing any Page as parameter - #9939
Merged
NathanWalker merged 1 commit intoJun 17, 2022
Conversation
NathanWalker
pushed a commit
that referenced
this pull request
Jul 9, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Jul 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The iOS app is leaking always after using the 'showModal' navigation to present any Page. According to the debugging, the entire page presented is leaking.
What is the new behavior?
The page presented by the 'showModal' navigation is being disposed of memory.