Repository navigation
fix(core): Animation iteration functionality was broken for android css animations and iOS rotation - #9628
Merged
NathanWalker merged 13 commits intoJan 23, 2022
Conversation
NathanWalker
previously approved these changes
Oct 29, 2021
CatchABus
marked this pull request as draft
October 30, 2021 00:05
Contributor
Author
|
I marked this PR as draft because there is 1 more thing I wish to test on iOS regarding these changes. |
CatchABus
changed the title
CatchABus
changed the title
CatchABus
changed the title
CatchABus
marked this pull request as ready for review
November 2, 2021 18:26
…to check if animation is already playing.
CatchABus
force-pushed
the
android-animation-iterations-fix
branch
from
November 3, 2021 11:34
29c1b01 to
d5b510d
Compare
Contributor
Author
|
I don't think this PR needs further changes. Just let me know if there is anything else I need to do to improve it. |
NathanWalker
approved these changes
Jan 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Animation iteration count is ignored when set in CSS for Android.
Also, rotate animations that ran programmatically in iOS were ignoring
iterations,curve, anddelayproperties.What is the new behavior?
Animation will consider iteration count even if it's set as
infinitein Android.Rotate animation will now consider all animation properties when run programmatically in iOS.
After few runs, these changes seemed good.
Fixes/Closes #7712 .
@NathanWalker In the case of android, an obsolete code was the main reason animation functionality had defects.
It seems this code was a part of much older NativeScript 1.5.x: a3d762d#diff-65943155215ba5170b0bd573cf98c4ec9663cba6c11babf37a8bed411db5d0c1
After taking a closer look, I realized it's literally no longer doing a thing since the implementation of
isPlayingflag check but can still cause harm.This PR is ready now and I can say these changes had positive results on my side.