Skip to content

svelte changes from halfnelson - #9497

Merged
rigor789 merged 5 commits into
NativeScript:masterfrom
Akylas:pullrequests/halfnelson/feat/webpack5
Aug 11, 2021
Merged

svelte changes from halfnelson#9497
rigor789 merged 5 commits into
NativeScript:masterfrom
Akylas:pullrequests/halfnelson/feat/webpack5

Conversation

@farfromrefug

@farfromrefug farfromrefug commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

I think this should do it from what he did

@cla-bot

cla-bot Bot commented Aug 4, 2021

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @halfnelson.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@farfromrefug

farfromrefug commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator Author

@rigor789 why is the bot asking for @halfnelson cla ...

@cla-bot

cla-bot Bot commented Aug 4, 2021

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @halfnelson.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@rigor789
rigor789 merged commit 59d9271 into NativeScript:master Aug 11, 2021
@farfromrefug
farfromrefug deleted the pullrequests/halfnelson/feat/webpack5 branch August 11, 2021 09:55
rigor789 added a commit that referenced this pull request Sep 7, 2021
@farfromrefug @halfnelson @rigor789
feat(webpack): improved svelte HMR (#9497)
b3ca5de 
* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
rigor789 added a commit that referenced this pull request Sep 7, 2021
@rigor789 @farfromrefug @halfnelson
feat: Frame replacePage by entry (#9460)
4a5bec1 
* feat: Frame replacePage by entry

* feat(webpack): improved svelte HMR (#9497)

* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>

* feat(webpack): use svelte-loader and fallback to svelte-loader-hot

Allows running older projects

* feat: allow overwriting replacePage transition

Co-authored-by: farfromrefuge <martin.guillon@akylas.fr>
Co-authored-by: halfnelson <dpershouse@gmail.com>
NathanWalker pushed a commit that referenced this pull request Sep 8, 2021
@rigor789 @farfromrefug
@halfnelson @NathanWalker
feat: Frame replacePage by entry (#9460)
ffab4c3 
* feat: Frame replacePage by entry

* feat(webpack): improved svelte HMR (#9497)

* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>

* feat(webpack): use svelte-loader and fallback to svelte-loader-hot

Allows running older projects

* feat: allow overwriting replacePage transition

Co-authored-by: farfromrefuge <martin.guillon@akylas.fr>
Co-authored-by: halfnelson <dpershouse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@farfromrefug @rigor789 @halfnelson