Repository navigation
fix: allow navigationFrom event for deep navigation within modal frame - #9187
Merged
Merged
Conversation
NathanWalker
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS if you were to use a frame modally, the deep(backStack >0)
navigatingFromevents were not fired.The reason is pretty simple, it was seen as modal and thus no event (yet
navigatingTowas fired...)That PR simply bypass the check if frame backstack length is > 0. That way we get the events for deep navigation but we still "skip" it when closing the modal itself.