Repository navigation
fix: prevent circular reference && Cannot access … before initialization - #9111
Merged
Merged
Conversation
Contributor
|
Thanks @farfromrefug we can further enforce/ensure only the If you'd like to make that one last additional improvement we'll get this merged and out in a patch. |
NathanWalker
approved these changes
Dec 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure why i dont see the issue in all apps but the issue is definitely there:
PageimportsFrameFrameimportsPageI ended up in a case where i got
Cannot access … before initializationbecause of that.By using
frame.constructor.name === 'Frame'nowFrameis just used as a type inpage-commonand thus we dont get a circular referecence anymore