Repository navigation
fix: bundle entry points - #8884
Conversation
# Conflicts: # packages/core/globals/index.ts
|
I think we did some tests with import vs. require and were seeing exactly what is commented on that thread here: Where using require as opposed to import seemed to be guarantee. |
|
Imports will all get at the top you are right. Which is why I changed the way initGlobals is called to ensure the right order. |
|
After that test with that code and you ll see the order being correct. |
|
LGTM - I'll just run a test and include a diff here with the before/after behavior. Left is old, right is new - the
|
|
Awesome thanks @farfromrefug and @rigor789 👍 |
|
Released with 7.0.5 https://github.com/NativeScript/NativeScript/releases/tag/7.0.5-core |
|
@NathanWalker i think it needs a webpack release too. #8778 |
As requested here is the PR again which fixes
This PR fixes a big issue which appeared with N 7 / esm / webpack
With webpack import / require order is not respected : webpack/webpack#1343
Now in bundle-config-loader we rely on
requireto loadbundle-entry-pointsthus callinginitGlobalsand making tslib functions global.Because it uses
requireit actually end up at the end of yourmain.js(simply look at a generated bundle.js)To keep that call up we need to use
importBut that is not enough!
in
bundle-entry-pointswe use 'require' on 'globals'. And usingimportis not enough either because we call a method on it which will end up after all imports!The solution to all this is call
initGlobalinsideglobal/index.tsthen useimport './global'for example.Doing that i needed cleanup a bit and we end up with only on use of
initGlobalEDIT: that app will crash on ios because of that. The reason is that i import View at the top of my main.ts which include files using
__metadata