Repository navigation
fix bundle-config-loader - #8838
Merged
Merged
Conversation
NathanWalker
previously approved these changes
Sep 10, 2020
Contributor
|
Thank you @farfromrefug ! |
NathanWalker
force-pushed
the
master
branch
from
September 10, 2020 03:15
9c97150 to
f7713c4
Compare
NathanWalker
force-pushed
the
bundle-entry-points
branch
from
September 10, 2020 03:33
069dbb9 to
8b11d11
Compare
Collaborator
Author
|
@NathanWalker can you guys test this on your side before we publish this? |
Collaborator
Author
|
Actually already released:) hope it won't break somewhere:) |
NathanWalker
pushed a commit
that referenced
this pull request
Sep 10, 2020
Collaborator
Author
|
@NathanWalker what happened here? That PR seems messed up. DOes not link to my branch anymore master...Akylas:bundle-entry-points And the issue is still here #8872 |
Contributor
|
The PR you had done here was from a branch on master called |
Collaborator
Author
|
@NathanWalker sorry misread ! But wait why is it my description if not my PR? What s going on here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a big issue which appeared with N 7 / esm / webpack
With webpack import / require order is not respected : webpack/webpack#1343
Now in bundle-config-loader we rely on
requireto loadbundle-entry-pointsthus callinginitGlobalsand making tslib functions global.Because it uses
requireit actually end up at the end of yourmain.js(simply look at a generated bundle.js)To keep that call up we need to use
importBut that is not enough!
in
bundle-entry-pointswe use 'require' on 'globals'. And usingimportis not enough either because we call a method on it which will end up after all imports!The solution to all this is call
initGlobalinsideglobal/index.tsthen useimport './global'for example.Doing that i needed cleanup a bit and we end up with only on use of
initGlobalEDIT: that app will crash on ios because of that. The reason is that i import View at the top of my main.ts which include files using
__metadata