Repository navigation
fix(android): dont dispose fragment on onloaded - #8793
Merged
NathanWalker merged 2 commits intoAug 11, 2021
Merged
NathanWalker merged 2 commits into
NathanWalker merged 2 commits into
Conversation
rely on android logic
This comment was marked as abuse.
This comment was marked as abuse.
Collaborator
Author
|
The initial crashing sample is not crashing anymore with this PR. At least I could not get it to crash |
NathanWalker
force-pushed
the
master
branch
from
September 10, 2020 15:42
8753605 to
86395da
Compare
farfromrefug
added a commit
to Akylas/NativeScript
that referenced
this pull request
Sep 16, 2020
3 of 5 tasks
NathanWalker
force-pushed
the
master
branch
from
September 25, 2020 23:16
d4ced42 to
53488b5
Compare
NathanWalker
added
the
ready for test
NathanWalker
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained here #6659
That hack has bad consequences.
Also i actually cant see any wrong behavior using the sample provided in the issue and upgrading to latest N.