Skip to content

chore(build): always use local typescript #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vakrilov merged 2 commits into from
Feb 5, 2020
Merged

chore(build): always use local typescript #8304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00d25ad
chore(build): always use local typescript
Feb 3, 2020
d2682a4
Merge branch 'release' into use-local-tsc
Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/generate-barrel-dts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ DIST=dist;
ROOT_DIR=$(cd `dirname $0` && pwd)/..;
cd "$ROOT_DIR"

# Aways execute npx tsc from repo root to use the local typescript
npx tsc -v
npx tsc -p nativescript-core/tsconfig.barrels.json

FROM="temp/dts-out"
Expand Down
9 changes: 6 additions & 3 deletions build/pack-compat.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@ set -e

## Pack tns-core-modules
(
cd "dist/tns-core-modules"

echo 'Run tsc ...'
npx tsc
# Aways execute npx tsc from repo root to use the local typescript
echo 'TypeScript transpile...'
npx tsc -v
npx tsc -p "dist/tns-core-modules"


echo 'NPM packing ...'
cd "dist/tns-core-modules"
TGZ="$(npm pack)"
mv "$TGZ" "../$TGZ"
)
7 changes: 5 additions & 2 deletions build/prepare-core.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,14 @@ mkdir -p "$DIST"
npx ncp README.md "$DIST"/"$PACKAGE"/README.md

(
echo 'TypeScript transpile...'
cd "$DIST/$PACKAGE"
npm install
npx tsc
)

# Aways execute npx tsc from repo root to use the local typescript
echo 'TypeScript transpile...'
npx tsc -v
npx tsc -p "$DIST/$PACKAGE"

echo "Clearing typescript definitions from private APIs..."
npx ts-node --project ./build/tsconfig.json build/clear-private-definitions "$DIST/$PACKAGE"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"tslint": "^5.4.3",
"typedoc": "^0.13.0",
"typedoc-plugin-external-module-name": "git://github.com/PanayotCankov/typedoc-plugin-external-module-name.git#with-js",
"typescript": "^3.1.6"
"typescript": "^3.7.5"
},
"scripts": {
"setup": "npm run build-core && npm run build-compat && npm run setup-link",
Expand Down
2 changes: 1 addition & 1 deletion tns-platform-declarations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
},
"homepage": "https://github.com/NativeScript/NativeScript#readme",
"devDependencies": {
"typescript": "^3.1.6"
"typescript": "^3.7.5"
}
}