fix: return default tab background color when the background color is not explicitely set through css #8240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the background color is not explicitely set through css
vtrifonov
force-pushed
the
trifonov/android-bn-backgroundColor-fix
branch
from
16eb2c5 to
7621d3b
Compare
vakrilov
approved these changes
Jan 14, 2020
This was referenced Mar 20, 2020
This was referenced Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When a tab's in tabs/bottom-navigation is activated and its background-color is changed it does not return to its default background-color after deactivating it.
What is the new behavior?
When a tab's in tabs/bottom-navigation is activated and its background-color is changed it returns to its default background-color after deactivating it.
Fixes #8235.