Skip to content

fix(android): handle fake attach #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vakrilov merged 1 commit into from
Dec 17, 2019
Merged

fix(android): handle fake attach #8200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nativescript-core/ui/bottom-navigation/bottom-navigation.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,14 +385,14 @@ export class BottomNavigation extends TabNavigationBase {

_onAttachedToWindow(): void {
super._onAttachedToWindow();
this._attachedToWindow = true;

// _onAttachedToWindow called from OS again after it was detach
// TODO: Consider testing and removing it when update to androidx.fragment:1.2.0
if (this._manager && this._manager.isDestroyed()) {
return;
}


this._attachedToWindow = true;
this.changeTab(this.selectedIndex);
}

Expand Down
6 changes: 3 additions & 3 deletions nativescript-core/ui/frame/frame.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,14 @@ export class Frame extends FrameBase {

_onAttachedToWindow(): void {
super._onAttachedToWindow();
this._attachedToWindow = true;


// _onAttachedToWindow called from OS again after it was detach
// TODO: Consider testing and removing it when update to androidx.fragment:1.2.0
if (this._manager && this._manager.isDestroyed()) {
return;
}


this._attachedToWindow = true;
this._processNextNavigationEntry();
}

Expand Down