fix(android): handle fake attach #8200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It looks like this fixes the crash, we were experiencing. |
DimitarTachev
approved these changes
Dec 17, 2019
vakrilov
pushed a commit
that referenced
this pull request
Jan 27, 2020
* fix the crash * chore: update MaterialComponents pod (#8176) * chore: update MaterialComponents pod * chore: remove copy of pod file in build script * chore: cut the 6.3.0 release (#8174) * hore: cut the 6.3.1 release * fix: handle fake attach after FragMgr is destroyed (#8200) * fix: check is disposed fragment is in the FragmentManager (#8201) * release: cut the 6.3.2 release Co-authored-by: hamidbsd <50081218+hamidbsd@users.noreply.github.com> Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com> Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
vtrifonov
added a commit
that referenced
this pull request
Feb 26, 2020
* fix the crash * chore: update MaterialComponents pod (#8176) * chore: update MaterialComponents pod * chore: remove copy of pod file in build script * chore: cut the 6.3.0 release (#8174) * hore: cut the 6.3.1 release * fix: handle fake attach after FragMgr is destroyed (#8200) * fix: check is disposed fragment is in the FragmentManager (#8201) * release: cut the 6.3.2 release * release: cut the 6.4.0 release * chore(build): always use local typescript * fix: flipLeft and flipRight on Android (#8307) * fix(android): tap-trip-item title disappearing * fix(andoid): crash when setting font on tab-item with no image * fix(build): Add platforms/android to NPM package (#8312) Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com> Co-authored-by: Alexander Vakrilov <alexander.vakrilov@gmail.com> * release: cut the 6.4.1 release * chore: bump tns-core-modules-widgets version (#8352) Co-authored-by: hamidbsd <50081218+hamidbsd@users.noreply.github.com> Co-authored-by: Alexander Vakrilov <alexander.vakrilov@gmail.com> Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com> Co-authored-by: Nick Iliev <nikolay.iliev@telerik.com> Co-authored-by: Martin Bektchiev <martin.bektchiev@progress.com> Co-authored-by: Rosen Vladimirov <rosen-vladimirov@users.noreply.github.com>
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Sometimes
_onAttachedToWindowis called by Android after the app has suspended. Usually there is another call to_onDetachFromWindowimmediately after, but on some version of android (reproduced on Oxygen 10 / OnePls 7T) there isn't. Which cause fragment manager calls too early in the lifecycle after the app is resumed and leads to crashes.What is the new behavior?
Set the
_attachedToWindowafter thethis._manager.isDestroyed()check to make sure it is not raised falsely.Fixes #8104