Skip to content

fix(8153): null reference exception in view.android.onUnloaded #8171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtopuzov merged 5 commits into from
Dec 13, 2019
Merged

fix(8153): null reference exception in view.android.onUnloaded #8171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32fb5bf
fix the crash
hamidbsd Nov 27, 2019
aeb266e
Merge branch 'master' into NativeScript/NativeScript
hamidbsd Dec 5, 2019
c5b7f43
docs: fix codeblocks (#8173)
Dec 6, 2019
f90309d
Merge branch 'master' into NativeScript/NativeScript
Dec 6, 2019
eee7040
Merge branch 'release' into NativeScript/NativeScript
dtopuzov Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ tag the release and update the CHANGELOG.md. Don't forget to check the auto-gene
cd nativescript-core
npm --no-git-tag-version version [major|minor|patch] -m "release: cut the %s release"
cd ..
```

5. Execute [`npm version`](https://docs.npmjs.com/cli/version) to bump the version of `tns-core-modules`,
tag the release and update the CHANGELOG.md. Don't forget to check the auto-generated CHANGELOG.md
Expand Down
8 changes: 5 additions & 3 deletions nativescript-core/ui/core/view/view.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,13 @@ export class View extends ViewCommon {
@profile
public onUnloaded() {
if (this.touchListenerIsSet) {
this.nativeViewProtected.setOnTouchListener(null);
this.touchListenerIsSet = false;
this.nativeViewProtected.setClickable(this._isClickable);
if (this.nativeViewProtected) {
this.nativeViewProtected.setOnTouchListener(null);
this.nativeViewProtected.setClickable(this._isClickable);
}
}

this._manager = null;
this._rootManager = null;
super.onUnloaded();
Expand Down