Skip to content

feat(ios-tabs): emit tabStripItem tap event #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchimev merged 2 commits into from
Aug 20, 2019
Merged

feat(ios-tabs): emit tabStripItem tap event #7693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df35d1
feat(tabs): emit tabStripItem tap event
vchimev Aug 19, 2019
82e31ae
Merge branch 'master' into vchimev/tabs/tap-event
vchimev Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tns-core-modules/ui/tabs/tabs.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,12 @@ class MDCTabBarDelegateImpl extends NSObject implements MDCTabBarDelegate {
owner._canSelectItem = false;
}

return shouldSelectItem;
}
const tabStripItems = owner.tabStrip && owner.tabStrip.items;
if (tabStripItems && tabStripItems[selectedIndex]) {
tabStripItems[selectedIndex]._emit(TabStripItem.tapEvent);
}

public tabBarWillSelectItem(tabBar: MDCTabBar, item: UITabBarItem): void {
//
return shouldSelectItem;
}

public tabBarDidSelectItem(tabBar: MDCTabBar, selectedItem: UITabBarItem): void {
Expand Down Expand Up @@ -123,7 +124,7 @@ class UIPageViewControllerImpl extends UIPageViewController {

let safeAreaInsetsBottom = 0;
let safeAreaInsetsTop = 0;

if (majorVersion > 10) {
safeAreaInsetsBottom = this.view.safeAreaInsets.bottom;
safeAreaInsetsTop = this.view.safeAreaInsets.top;
Expand Down