feat: flexbile font icon usage in tab navigation #7672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoldonev
reviewed
Aug 14, 2019
...ules-widgets/android/widgets/src/main/java/org/nativescript/widgets/BottomNavigationBar.java
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Aug 14, 2019
tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/TabsBar.java
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Aug 14, 2019
manoldonev
reviewed
Aug 14, 2019
tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Aug 14, 2019
tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Aug 15, 2019
manoldonev
reviewed
Aug 15, 2019
tns-core-modules/ui/tab-navigation-base/tab-strip-item/tab-strip-item.ts
Outdated
Show resolved
Hide resolved
manoldonev
approved these changes
Aug 15, 2019
MartoYankov
force-pushed
the
myankov/more-font-icons
branch
from
121edfc to
38a1b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables more flexible declaration and manipulation of font icons as tab bar icons. Utilizes the nested Image and Label elements better.
Part of the 6.1 release for the Tab Navigation story - #6967
Fixes #7623
Fixes #7506
Fixes #7470
Fixes #7547