Skip to content

fix: expose missing css background* properties on View - #7032

Merged
manoldonev merged 2 commits into
releasefrom
mdonev/background-props-fix
Mar 15, 2019
Merged

fix: expose missing css background* properties on View#7032
manoldonev merged 2 commits into
releasefrom
mdonev/background-props-fix

Conversation

@manoldonev

@manoldonev manoldonev commented Mar 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Expose backgroundSize, backgroundRepeat, and backgroundPosition on View. Previously they were only accessible through View.style property and could not be set through xml markup, only css.

This will now work:

<Button backgroundImage="url('https://d2odgkulk9w7if.cloudfront.net/images/default-source/home/header-graphic-hp-min.png?sfvrsn=31b70efe_6')"
    borderRadius='125' borderWidth='1' borderColor='black'
    backgroundRepeat="no-repeat" backgroundSize="contain"
    backgroundPosition="center" height='150' width='150' />

Fixes: #6978

@manoldonev manoldonev self-assigned this Mar 14, 2019
@cla-bot cla-bot Bot added the cla: yes label Mar 14, 2019
@ghost ghost added the in progress label Mar 14, 2019
@manoldonev

manoldonev commented Mar 14, 2019

Copy link
Copy Markdown
Contributor Author

test package_version#latest

@SvetoslavTsenov
SvetoslavTsenov force-pushed the mdonev/background-props-fix branch from d0bbd85 to 9fa76bb Compare March 15, 2019 10:50
@ghost ghost assigned SvetoslavTsenov Mar 15, 2019
@SvetoslavTsenov

SvetoslavTsenov commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

test package_version#latest

@manoldonev
manoldonev merged commit 88f2242 into release Mar 15, 2019
@manoldonev
manoldonev deleted the mdonev/background-props-fix branch March 15, 2019 15:42
@ghost ghost removed the in progress label Mar 15, 2019
@manoldonev manoldonev mentioned this pull request Mar 15, 2019
Merged
@lock

lock Bot commented Mar 17, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@SvetoslavTsenov SvetoslavTsenov SvetoslavTsenov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@manoldonev manoldonev

@SvetoslavTsenov SvetoslavTsenov

Labels

cla: yes e2e test needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manoldonev @SvetoslavTsenov